[tuw_aruco] specifying range is not valid for string parameters

tuw-robotics / tuw_marker_detection

28 stars 28 forks source link

[tuw_aruco] specifying range is not valid for string parameters #2

Closed mikaelarguedas closed 5 years ago

mikaelarguedas commented 5 years ago

It seems that this compiles due to a faulty check in dynamic_reconfigure.

As specifying a range for a string parameter doesn't have much semantic value, this PR removed the range so that this package still compiles once https://github.com/ros/dynamic_reconfigure/pull/122 is merged and released

doctorseus commented 5 years ago

Thanks for reporting, http://wiki.ros.org/dynamic_reconfigure/Tutorials/HowToWriteYourFirstCfgFile indeed specifies that min/max doesn't apply to strings. Merged the commit with the fix to kinetic-devel first as this pull request targets kinetic directly. @maxbader please merge it to kinetic once you have reviewed it. Thanks!

mikaelarguedas commented 5 years ago

Thanks @doctorseus.

In case it saves you time in the future: Github allows to change the target branch of a PR by using the "Edit" button next to the PR title.