tuwien-csd / damap-backend

MIT License
5 stars 6 forks source link

40 add a format value to dataset info #238

Closed rekt-hard closed 1 month ago

rekt-hard commented 1 month ago

Description

Feature

What does this PR do?

Add file format attribute to dataset. Update fits mapper to use mime type for setting this attribute. Set attribute to empty string for OpenAIRE dataset, as this info is not available via the API. Update export to set the file format for new datasets table.

Restructure change log imports to import one change log per major version. This keeps the root change log as short as possible.

image

Breaking changes

Code review focus

Dependencies

Checks

closes https://github.com/tuwien-csd/damap-frontend/issues/40

ValentinFutterer commented 1 month ago

Also general warning: https://github.com/tuwien-csd/damap-backend/pull/227 has liquibase chnages, this will lead to conflicts, so whoever merges it should proceed with caution.

ValentinFutterer commented 1 month ago

I searched a little and found a dataset on OpenAire with a format: 10.48436/tkkfs-11b75 I tested it with this DOI and the dataset had null has fileFormat. The same happened when I added a dataset through the fits service. But inside the OpenAireMapper, the DatasetDO gets assigned the fileFormat correctly - there must be a bug somewhere else.

sonarcloud[bot] commented 1 month ago

Quality Gate Failed Quality Gate failed

Failed conditions
57.7% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud