tuwien-csd / damap-backend

MIT License
5 stars 6 forks source link

Template: Add reasons for closed and restricted dataset from frontend into templates #265

Closed GeoffreyKarnbach closed 1 month ago

GeoffreyKarnbach commented 1 month ago

Description

Add reasons for closed and restricted dataset from frontend questions into all templates

Template files

FWFTemplate.docx horizonEuropeTemplate.docx scienceEuropeTemplate.docx

Checks

closes GH-

ValentinFutterer commented 1 month ago

Core functionality works great but i have a suggestion for an addition:

Befire, the dewcriptions for the repos were the only free text under the table, but now we have the reasons for closing/restricting a dataset here - therefore i would suggest adding headings, to keep the sections seperate from each other.

image

You can look at how its done in other parts of the templates:

image

This would also remove the issue of just two empty lines being here, when the user gave no input. Remember to remove the headlines (and the empty lines), if no dataset is restricted/closed.

ValentinFutterer commented 1 month ago

I didnt notice during my first review, but this table is completely thrown out of whack 😅 Pls fix, then i will review the other changes.

image
sonarcloud[bot] commented 1 month ago

Quality Gate Failed Quality Gate failed

Failed conditions
44.4% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud