tuwien-csd / damap-backend

MIT License
5 stars 6 forks source link

Export: IdentifierTypes are not compared correctly #266

Closed ValentinFutterer closed 1 month ago

ValentinFutterer commented 1 month ago

Describe the bug In AbstractTemplateExportScienceEuropeComponent , this line 130 if (personIdentifier.getIdentifierType().toString().equals("orcid")) { causes problems. This comparison doesnt work, since the Enum is ORCID and not orcid. The same happens for other identifiers, like ROR. This leads to the identifiers missing in the contributor section of the export.

image

To fix this, do the comparison using the actual enums.

Is this a regression? Yes.

Expected behavior Comparisons should work like intended, see screenshot above.

Environment