CostsDescriptions: Add the description for a cost below the table whe…

andresTabiTuwien commented 1 month ago

Description

Add the description of the cost that is too long to fit in the table. Place the description below the table of costs.

https://github.com/tuwien-csd/damap-backend/issues/76

What does this PR do?

Cost descriptions that are too long are now placed below the table.

Breaking changes

Code review focus

Check that the description is longer than 255 characters and appears below the cost table.

Dependencies

Checks

[ ] Tested with Oracle/PostgreSQL
[ ] Export updated
[ ] Documentation added
[ ] Tests added
[ ] E2e tests created
[ ] Successfully ran e2e tests before merge

FWFTemplate_review.docx horizonEuropeTemplate_review.docx scienceEuropeTemplate_review.docx

closes GH-76

ValentinFutterer commented 3 weeks ago

All in all works pretty well 👍 I have a small suggestion to add - could you make the description column wider and the unit column smaller? The unit column doesnt need the space and the description column for sure does.

ValentinFutterer commented 2 weeks ago

Your last changes might have broken some stuff that already worked 😅 , e.g., if i put in no cost, this output happens when exporting:

sonarcloud[bot] commented 2 weeks ago

Quality Gate failed

Failed conditions
70.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

tuwien-csd / damap-backend