tuwien-csd / damap-frontend

MIT License
9 stars 9 forks source link

tests: add schema to test cases #212

Open rekt-hard opened 2 weeks ago

rekt-hard commented 2 weeks ago

Description

Tests

What does this PR do?

In a unit test, only the tested component is of interest. Child components will have their own tests thus there is no need to verify their attributes. Adding CUSTOM_ELEMENTS_SCHEMA or NO_ERRORS_SCHEMA to the testbed suppresses the warnings about child component attributes.

Breaking changes

Code review focus

Dependencies

Checks

closes #213

sonarcloud[bot] commented 2 weeks ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

lpandath commented 1 week ago

@rekt-hard whilte I added an issue to test the test cases and saw that we also have this warning. Was this intended to leave it? WARN: 'NG0313: Multiple pipes match the name translate in the 'DmpActionsComponent' component. check the imports of this module'

rekt-hard commented 1 week ago

@lpandath: These should be addressed as well. I did not yet have time to do so. We can leave this PR open and fix them here or create a separate PR.