DMPStepper: Make evident if a section is locked

andresTabiTuwien commented 2 months ago

Feature

Description

Set the icon for when a step is blocked and requires action.

https://github.com/tuwien-csd/damap-frontend/issues/35

What does this PR do?

Change the icons for steps in the stepper on dmpComponent where an action is required. For example, step 4 requires a dataset that was previously registered in step 3.

Before

Now the icon when a step is blocked is a lock, and when a step is even empty, the step color remains gray.

Breaking changes

Code review focus

Dependencies

Checks

[ ] Summary updated
[ ] Version view updated
[ ] Documentation added
[ ] Tests added
[ ] E2e tests created
[ ] Successfully ran e2e tests before merge

closes GH-35

ValentinFutterer commented 2 months ago

Hey I have a few comments on this: To my understanding, the goal was to mark a section as locked to prevent people from needlessly clicking on it. But with your implementation, the "locking" only triggers when a user clicks on a "locked" section, which defeats the whole purpose.

In the same vein, you should probably use another icon to signal "lockedness" (most likely a lock). Warning indicates that something is wrong or dangerous or should be looked at - but what we want to signal is, that you cant/shouldnt look at this part right now.

It would also be cool, if there is an icon for empty (suggestion just the grey number), one for filled out at least part of the step (suggestion pencil) and one for locked. Right now the pencil just stands for clicked on, which isnt really helping when navigating the tool. A clear seperation would help immensely.

Also, your icons are larger than the standard ones, which leads to a situation, where the icon that is in focus is smaller than its peers.