tuwien-csd / damap-frontend

MIT License
10 stars 10 forks source link

Dashboard: Add content to the last two flip cards #340

Closed andresTabiTuwien closed 1 month ago

andresTabiTuwien commented 1 month ago

Description

Add content to the two flip cards (How to create a DMP and About DAMAP) in the home page.

https://github.com/tuwien-csd/damap-frontend/issues/331

What does this PR do?

image image

Breaking changes

Code review focus

Dependencies

Checks

closes GH-331

ValentinFutterer commented 1 month ago

I have a few small suggestions to add:

This verbiage is outdated and should reflect that we also offer an HE template

image

Is it possible to color these points? This would make it look more aligned with the About DAMAP tab, whose icons are also colored in the primary color.

image

Lastly, i would suggest to make these cards visually different from the upper two in same way, to highlight that they are less important. From the top of my head, this could be color, size, a question amrk or info icon, etc...

@ChristianeStork do you have something to add?

All in all i like it a lot, it looks way more appealing that the old text wall 😄

lpandath commented 1 month ago

Description

Add content to the two flip cards (How to create a DMP and About DAMAP) in the home page.

331

What does this PR do?

image image

Breaking changes

Code review focus

Dependencies

Checks

* [ ]  Summary updated

* [ ]  Version view updated

* [ ]  Documentation added

* [ ]  Tests added

* [ ]  E2e tests created

* [ ]  Successfully ran e2e tests before merge

closes GH-331

Hi,

Second opinion: I think we could use Angular Material’s Expansion Panel in an accordion style. This would help us organize the content better and avoid showing too much text at once, which users often miss. With the accordion, we can add icons for each step, and it also includes a ‘Next’ step 'What is a DMP, ...', making it easier to follow.

It would make the design cleaner and more user-friendly. What do you think of this idea @ChristianeStork ?

Screenshot 2024-10-21 at 11 25 08
andresTabiTuwien commented 1 month ago

Description

Add content to the two flip cards (How to create a DMP and About DAMAP) in the home page.

331

What does this PR do?

image image

Breaking changes

Code review focus

Dependencies

Checks

* [ ]  Summary updated

* [ ]  Version view updated

* [ ]  Documentation added

* [ ]  Tests added

* [ ]  E2e tests created

* [ ]  Successfully ran e2e tests before merge

closes GH-331

Hi,

Second opinion: I think we could use Angular Material’s Expansion Panel in an accordion style. This would help us organize the content better and avoid showing too much text at once, which users often miss. With the accordion, we can add icons for each step, and it also includes a ‘Next’ step 'What is a DMP, ...', making it easier to follow.

It would make the design cleaner and more user-friendly. What do you think of this idea @ChristianeStork ? Screenshot 2024-10-21 at 11 25 08

@lpandath something like this: image

ChristianeStork commented 1 month ago

Thanks, everybody, that looks great! I love the accordion and the icons in the How to create a DMP section. Please add HE in the ABOUT DAMAP section as well: "Delivers DMPs for FWF and Horizon Europe projects in the funder-specific formats." Are you planning to link to damap.org in the ABOUT DAMAP text?

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
11 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud