tuwien-csd / damap-frontend

MIT License
10 stars 10 forks source link

Version: Add new columns to DMP Table to display version count and last version name #354

Closed GeoffreyKarnbach closed 2 weeks ago

GeoffreyKarnbach commented 2 weeks ago

Description

Feature

What does this PR do?

Added two new columns to the DMP Table (Version count and Version name) to raise awareness about the existing versioning feature.

Breaking changes

Fixed a major bug regarding the length of the Versioning name in the frontend (as well as the backend),

Dependencies

Related backend PR, see:

https://github.com/tuwien-csd/damap-backend/pull/277

Checks

closes GH-346

ValentinFutterer commented 2 weeks ago

Good work! Can you add the versionName and versionNumber to the filter function of dataSource in dmp-table.component.ts, i think it would make sense to be able to search for them, especially the versionName.

sonarcloud[bot] commented 2 weeks ago

Quality Gate Failed Quality Gate failed

Failed conditions
55.6% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud