Open andresTabiTuwien opened 1 week ago
Very good, i would just add some minor functionality changes
Selecting a funder id over dropdown should also preselect the type - otherwise a user has no idea what kind of ID this is.
Also, if a funder id is selected, it should be mandatory to select an id type and vice-versa, same for grant_is. See the RDA-Common standard
Small info: The previous implementation was that the user should have a template preselected, only if there is funding. Otherwise nothing should be preselected.
For some weird reason, these values are lowercase, the enum is in upper case though.
Failed conditions
14.4% Coverage on New Code (required ≥ 80%)
3.1% Duplication on New Code (required ≤ 3%)
… project acronym add fields for funder and grant
Description
Add two fields for manual entry of the project, the funder and grant fields. For each of these there is also a drop down box to select the type of data for the fields.
https://github.com/tuwien-csd/damap-frontend/issues/325
What does this PR do?
Breaking changes
Code review focus
Dependencies
Checks
closes GH-325