search

tuxBurner / play-neo4jplugin

Neo4J Plugin for Play 2.4
39 stars 11 forks source link

Add support for SDN 4.0.0 #22

Closed patxiperpetuall closed 8 years ago

patxiperpetuall commented 9 years ago

Hi @tuxBurner,

I would appreciate a lot if you could update the plugin to support Spring Data Neo4j 4.0.0

I am apparently having some issues with current SDN.

Thanks for your work :)

DwayneSmurdon commented 9 years ago

Hah. I just came here to open the same issue. I hadn't realized this wasn't using the latest version of SDN. I had been reading the SDN 4.0 documentation and some of it didn't work in my code (likely because it's 4.0 specific).

I may play with switching out SDN 3.4 with SDN 4.0 and submit a pull request.

SDN 4.0, it seems, can be quite a bit different that earlier version, with some functionality being removed. So, it's possible that it might be better to fork and have two versions of this plugin. One working with SDN 3.4 (and perhaps anything up to but not including 4.0) and another with SDN 4.0 and beyond.

tuxBurner commented 9 years ago

Hi guys,

i will start working on this

nayish1 commented 9 years ago

Hi,

Can you open a branch and put your partial code for SDN 4 so maybe others can help with pull requests?

thanks, Nahchson

DwayneSmurdon commented 9 years ago

Sounds great. I agree with Nahchson, if you post, perhaps we can help. :)

amitsz commented 9 years ago

There is update of the plugin? i'm waiting for it.

tuxBurner commented 9 years ago

Hi guys sorry for the late response :) I am at vacations @ the moment. Tomorrow i am coming home :)

DwayneSmurdon commented 9 years ago

I don't recall us approving your vacation time. ;)

tuxBurner commented 9 years ago

Hi started the work in the branch sdn4.0 :) Lots of changes there but looking forward.

DwayneSmurdon commented 9 years ago

Any update on this? :) I started a port and had to make a ton of changes and then I got into a state that won't run at all. Now my current version with SDN 3.4 is broken, too. I really wish I had pushed some code along the way, but I didn't. I'm about to download and start over.

DwayneSmurdon commented 8 years ago

Hey @tuxBurner! Just checking in to see if there's any more progress here. Does the sdn4.0 branch work? I'm going to be starting a new project soon, so I'm hoping to base it on sdn4.0. :)

unterstein commented 8 years ago

Hi all,

SDN 4.0 was not able to start in play, because of some strange classloading issues in SDN and OGM. @tuxBurner and me was involved to solve this issues for SDN 4.1, see https://jira.spring.io/browse/DATAGRAPH-830 and https://github.com/spring-projects/spring-data-neo4j/issues/315.

I am starting to integrate SDN 4.1 (currently only snapshot) this evening and if you like, we will contribute a SNAPSHOT release. Is this ok für you?

Cheers Johannes

DwayneSmurdon commented 8 years ago

Yes @unterstein, please do a snapshot. If I have time this weekend, I'll see how it works for me and report back. Thank you for working on this, Johannes.

-Dwayne

tuxBurner commented 8 years ago

Hi thaaaaanks a lot to @unterstein :)

@DwayneSmurdon i released a Snapshot 1.5.1 in my repo you can test :)

DwayneSmurdon commented 8 years ago

@tuxBurner - I bet you're glad to be able to close this one. I'll try to do some testing, soon.