search

tuxedocomputers / tuxedo-keyboard

This repository will no longer get any updates as the code here is now part of tuxedo-drivers https://gitlab.com/tuxedocomputers/development/packages/tuxedo-drivers.
https://gitlab.com/tuxedocomputers/development/packages/tuxedo-drivers
GNU General Public License v3.0
300 stars 94 forks source link

Upstream location #200

Closed Ionic closed 1 year ago

Ionic commented 1 year ago

Can you please add pointers to the upstream location or make your Gitlab project public?

For instance, I've been looking at 5c9ca122cca5932ec12d1967460519efd0d87894 and noticed that the linked issue (#79) has nothing to do with the code fixing it. Further digging revealed the merge commit a9df75b12f78e1e852e644723036d67f6abd6106, which points to a MR called tuxedocomputers/development/packages/tuxedo-keyboard!51, which is syntax Gitlab uses.

I kept looking and discovered https://gitlab.com/tuxedocomputers/development, but that project doesn't contain a public tuxedo-keyboard project. Not sure if it's private, renamed, moved to a different location or whatever happened, but I wasn't able to get the information I needed.

Please add pointers to the correct upstream location.

tuxedoxt commented 1 year ago

Hello,

  1. github is used as the official upstream location so that is still already the answer.
  2. Yes the autoclose & autoreferencing is somewhat annoying when used like this. Until now not found a way to turn this feature off in github.

Could still happen that we switch to official gitlab in the future.

Ionic commented 1 year ago

The point is that, as a software engineer working on that piece of code, without the metadata/discussion provided in the linked MR and bug report, I can at best only guess at what it is supposed to do.

Right now, the change description could have equally been "changed something", which is utterly useless. However, the information that actually explains it is contained in some other repository, but that one seems to be private. Can't you make it public, at least read-only? Ideally, this kind of information should be part of the detailed commit message (i.e., what follows the first sentence/line) anyway, but I can only request better commit messages for future work. For stuff already published, at least make sure that linked information can actually be accessed, please.