search

tuxera / ntfs-3g

NTFS-3G Safe Read/Write NTFS Driver
https://www.tuxera.com/company/open-source
GNU General Public License v2.0
985 stars 149 forks source link

Patches from AOSC-Dev #4

Open ratijas opened 3 years ago

ratijas commented 3 years ago

There are some patches in AOSC community made back in 2019 against an imported repository dating as far as version 2017.3.23. From what I can tell, they never made it here upstream. And at least one patch is a nice quality of life improvement regarding suid handling. Should we try to accept these patches now?

https://github.com/AOSC-Dev/ntfs-3g/commits/master

Artoria2e5 commented 3 years ago

(There was some issue with the ML in that JPA and I forgot to click "reply all". So I will be quoting nonexistent stuff, sorry.)

I think https://github.com/AOSC-Dev/ntfs-3g/commit/9189a4ab815241b4e073079744c4fadd429d715a and https://github.com/AOSC-Dev/ntfs-3g/commit/c918fb79f9f340bce1a19dacf4b720d19922450d are the two worth cherry-picking. The former is trivial and may have been independently fixed. The latter was proposed in the ML; the gist of my argument was that a system libfuse2 would be about as safe as a static libfuse-lite since the setuid on ntfs-3g prevents LD_PRELOAD and other shenanigans.

The big_writes thing is already upstream. My two commits were a bit misguided in that I basically ported libfuse3 features (the even bigger 1MB buffer) to the internal libfuse2 copy. That was obviously a bad idea compared to porting to libfuse3 wholesale, but neither Tuxera nor I had the combined energy+intention to do it.