search

tuxera / ntfs-3g

NTFS-3G Safe Read/Write NTFS Driver
https://www.tuxera.com/company/open-source
GNU General Public License v2.0
1k stars 149 forks source link

configure.ac: fix bashism in fuse check #58

Closed thesamesam closed 2 years ago

thesamesam commented 2 years ago

configure scripts need to be runnable with a POSIX-compliant /bin/sh.

On many (but not all!) systems, /bin/sh is provided by Bash, so errors like this aren't spotted. Notably Debian defaults to /bin/sh provided by dash which doesn't tolerate such bashisms as '=='.

This retains compatibility with bash.

Fixes configure warnings/errors like:

checking Windows OS... no
./configure: 13360: test: xinternal: unexpected operator
checking for pthread_create in -lpthread... yes
checking Solaris OS... no

Signed-off-by: Sam James sam@gentoo.org

unsound commented 2 years ago

Looks good to me (and I'm the one who accidentally introduced that bashism).

thesamesam commented 2 years ago

@jpandre any chance you could take a look? cheers!

jpandre commented 2 years ago

Well, your proposal has been approved (I also agree with it), and it is not security related. You only have to wait for the next release.

unsound commented 2 years ago

This has been approved and cherry-picked into edge, so it's good for inclusion in the next release. Thanks!

Neustradamus commented 1 year ago

Commit is here: