tuxfoo / jellyfin-skill

This skill allows audio playback from a Jellyfin server
Other
8 stars 4 forks source link

few different issues #14

Open pbanj opened 3 years ago

pbanj commented 3 years ago

saying "play 'xxxxx'" leads to mycroft saying it isnt sure how to play it. which leads to the other issue. if you say "play 'xxxxx' from jelly fin" it will then say it is playing what you asked but in reality it just shuffles all your music.

image

says this too if you dont add the intent

tuxfoo commented 3 years ago

Thanks for the feedback.

I have not used Mycroft in a while, I still used Jellyfin a lot. I just ordered Respeaker 4 mic array hat for raspberry pi so that might motivate me to do some more work on the Jellyfin skill once it arrives.

I will attempt to automate some testing, monitor both jellyfin and mycroft logs.

tuxfoo commented 3 years ago

Can you try this again with the latest master. It should now only shuffle if you ask it to. Both with and without the "from jellyfin" intent.

If you are using a raspberry pi: There is a bug with picroft with the Common Play framework, so it might not work on Raspberry Pi without the "from jellyfin" intent. What happen's is CPS times out before it has finished querying the Jellyfin server, the audio control skill ignore's requests to extend this time out, there was a PR to fix this. This might also happen on other slow devices or networks.

pbanj commented 3 years ago

ya, might be a week or so though. im currently moving a bunch of networking shit around in my house and havent set mycroft back up

mike99mac commented 2 years ago

Hi, I was working with Jellyfin and mycroft, but switched to Emby for some reason I can't remember. Now I'm reminded that Emby is closed source and Jellyfin is open. I'm thinking of switching back.

I've been working on improving the Emby-Mycroft skill. I made a couple of videos here: https://www.youtube.com/watch?v=Crre3LWnQ0Q (13+ min) and here: https://www.youtube.com/watch?v=udE66fLkNxY (5+ min)

The code is here: https://github.com/mike99mac/emby-skill-mike99mac

Would anyone be up for working with me to integrate this code into the Jellyfin skill? my email is mike99mac at gmail.com if off list is better. Thanks.