tuxis-ie / nsedit

DNS Editor working with PowerDNS's new API
GNU General Public License v2.0
199 stars 55 forks source link

Separated RUN-commands, changed a sed-command because the matching did not work #155

Closed maltris closed 6 years ago

maltris commented 7 years ago

Its good to make separate layers by running commands separately (e. g. in order to speed up development).

tuxis-ie commented 7 years ago

The upside of && is that if a command fails, the rest of the commands will not be executed. How does RUN handle that?

maltris commented 7 years ago

Its very easy to try:

Dockerfile:

RUN exit 1

Output:

Step 8/10 : RUN exit 1
 ---> Running in 8ffbeff600d4
The command '/bin/sh -c exit 1' returned a non-zero code: 1
maltris commented 6 years ago

Hi, will it be merged? :)