search

tuxis-ie / nsedit

DNS Editor working with PowerDNS's new API
GNU General Public License v2.0
196 stars 55 forks source link

php 7.1 issue #156

Open jostreff opened 7 years ago

jostreff commented 7 years ago

Dear All,

have anyone tryed this great web interface running on php7?

My attempt to use it under php 7.1.8 was failure.

tuxis-ie commented 7 years ago

Haven't tried that yet, no. Feel free to debug and send in a PR

metrax commented 6 years ago

I'm using PHP 7.1.12 and had no problems yet.

hurricanerainbow commented 6 years ago

On 7.2 works fine too, except I had to install MCrypt via PECL since Debian doesn't have it ready for 7.2 in sid yet.

ghost commented 6 years ago

have it running on PHP 7.0 and no issues so far... the thing between 7.0 and 7.1 should effectively only be mcrypt as @ericcotelnu said.

Please see http://php.net/manual/de/migration71.deprecated.php for details and why PHP is dropping mcrypt (it is out of date). Seems the update should be easy enough though: it would be enough to change the enc_secret + dec_secret functions in includes/session.inc.php to something else. IMHO you'd ideally drop the dec_secret completely (no auto-login... that's a bad idea anyway) and exchange the enc_secret with just a simple hash() call...