search

tuxis-ie / nsedit

DNS Editor working with PowerDNS's new API
GNU General Public License v2.0
198 stars 55 forks source link

notify pdns after zone update #166

Closed Rico29 closed 6 years ago

Rico29 commented 6 years ago

fix #165

tuxis-ie commented 6 years ago

Looks good. Thanks.

tuxis-ie commented 6 years ago

I missed something. $notifyafterupdate is not set anywhere and thus will cause a lot of PHP Notice: Undefined variable/. Can you fix that please?

HLFH commented 6 years ago

@tuxis-ie Sending a DNS NOTIFY to all slaves can be done at the pdns level without these commits. Is this PR needed?

tuxis-ie commented 6 years ago

Well, this tells pdns to do the notify. What would you suggest?

HLFH commented 6 years ago

Raising the serial number of a domain suffices to trigger PowerDNS to send out notifications. When a zone is updated in master using nsedit, the serial of the zone changes, therefore, the master sends a NOTIFY to the slave. I think this code is duplicating NOTIFY requests. Therefore, I would suggest not to add any commits about this.