Closed ligi closed 8 years ago
If the simplification does not depend on SDK 23 I would prefer to split the changes into two separate commits.
Why?
Separation of concerns. The SDK 23 update might introduce changes that cannot be forseen. This has nothing to do with the simplification as I understood.
I do not see the advantage in splitting this
Separate concerns allows for cherry-picking to other branches, easier debugging to find the exact commit which causes the error (divide and conquer as in Git bisect).
I understand this - still do not see the advantage for this particular commit - added you as collaborator - you can change the branch if you want - I will not waste time with this
I split the commit and opened two separate pull requests here: #119 and #120.
closing this one then
This iterating over the variants/outputs is not needed anymore - there is now a way more elegant way to do the same