tuxmobil / CampFahrplan

View the conference schedule of the Chaos Communcation Camp/Congress
59 stars 23 forks source link

Simplify gradle file and use SDK 23/Appcompat 23.1.1 #117

Closed ligi closed 8 years ago

ligi commented 8 years ago

This iterating over the variants/outputs is not needed anymore - there is now a way more elegant way to do the same

johnjohndoe commented 8 years ago

If the simplification does not depend on SDK 23 I would prefer to split the changes into two separate commits.

ligi commented 8 years ago

Why?

johnjohndoe commented 8 years ago

Separation of concerns. The SDK 23 update might introduce changes that cannot be forseen. This has nothing to do with the simplification as I understood.

ligi commented 8 years ago

I do not see the advantage in splitting this

johnjohndoe commented 8 years ago

Separate concerns allows for cherry-picking to other branches, easier debugging to find the exact commit which causes the error (divide and conquer as in Git bisect).

ligi commented 8 years ago

I understand this - still do not see the advantage for this particular commit - added you as collaborator - you can change the branch if you want - I will not waste time with this

johnjohndoe commented 8 years ago

I split the commit and opened two separate pull requests here: #119 and #120.

ligi commented 8 years ago

closing this one then