tuxnsk / nodejs_libmodbus

libmodbus binding for nodejs
41 stars 66 forks source link

Can't build on Linux Mint - Werror problem #3

Closed chaser92 closed 10 years ago

chaser92 commented 10 years ago

The patch to libmodbus that you have provided has some warnings, and can't compile because of Werror (treat warnings as errors). I have resolved this issue. See my fork at https://github.com/chaser92/nodejs_libmodbus.

Could you please consider adding this fix to the official repo and npm?

tuxnsk commented 10 years ago

add you patch

2014/1/7 chaser92 notifications@github.com

The patch to libmodbus that you have provided has some warnings, and can't compile because of Werror (treat warnings as errors). I have resolved this issue. See my fork at https://github.com/tuxnsk/nodejs_libmodbus.

Could you please consider adding this fix to the official repo and npm?

— Reply to this email directly or view it on GitHubhttps://github.com/tuxnsk/nodejs_libmodbus/issues/3 .

Contacts: http://tuxnsk.ru/

chaser92 commented 10 years ago

Thank you. Closing the issue

reeshkov commented 10 years ago

I got error too:

make: *\ [all] Ошибка 2 npm WARN This failure might be due to the use of legacy binary "node" npm WARN For further explanations, please read /usr/share/doc/nodejs/README.Debian

modbus@0.0.12 preuninstall /usr/local/lib/node_modules/modbus rm -rf libmodbus build

npm ERR! modbus@0.0.12 install: ./make_libmodbus.sh && node-gyp configure --python=python2 && node-gyp build npm ERR! sh "-c" "./make_libmodbus.sh && node-gyp configure --python=python2 && node-gyp build" failed with 2 npm ERR! npm ERR! Failed at the modbus@0.0.12 install script. npm ERR! This is most likely a problem with the modbus package, npm ERR! not with npm itself. npm ERR! Tell the author that this fails on your system: npm ERR! ./make_libmodbus.sh && node-gyp configure --python=python2 && node-gyp build npm ERR! You can get their info via: npm ERR! npm owner ls modbus npm ERR! There is likely additional logging output above.

npm ERR! System Linux 3.11.0-12-generic npm ERR! command "/usr/bin/nodejs" "/usr/bin/npm" "install" "-g" "modbus" npm ERR! cwd /root npm ERR! node -v v0.10.15 npm ERR! npm -v 1.2.18 npm ERR! code ELIFECYCLE npm ERR! npm ERR! Additional logging details can be found in: npm ERR! /root/npm-debug.log npm ERR! not ok code 0 andrey-w ~ # cat /usr/share/doc/nodejs/README.Debian|less

tuxnsk commented 10 years ago

reeshkov, ÇÌÑÎØ ÜÔÕ ×ÅÔËÕ https://github.com/tuxnsk/nodejs_libmodbus/issues/5 ÓËÏÒÅÅ ×ÓÅÇÏ ÎÅ È×ÁÔÁÅÔ ËÁËÉÈ-ÌÉÂÏ ÕÔÉÌÉÔ ÄÌÑ ÓÂÏÒËÉ, ÔÁÍ ÅÓÔØ ÓÏ×ÅÔÙ, ÎÁÌÉÞÉÅ ËÁËÉÈ ÕÔÉÌÉÔ ÎÅÏÂÈÏÄÉÍÏ ÐÒÏ×ÅÒÉÔØ É ËÁË ÍÏÖÎÏ ×ÒÕÞÎÕÀ ÐÏÐÒÏÂÏ×ÁÔØ ÏÔËÏÍÐÉÌÉÒÏ×ÁÔØ ÍÏÄÕÌØ, ÞÔÏÂÙ ÐÏÌÕÞÉÔØ ÂÏÌÅÅ ÐÏÄÒÏÂÎÙÊ ×Ù×ÏÄ ÌÏÇÁ ÏÛÉÂËÉ

2014-02-09 reeshkov notifications@github.com:

I got error too:

make: *\ [all] ïÛÉÂËÁ 2 npm WARN This failure might be due to the use of legacy binary "node" npm WARN For further explanations, please read /usr/share/doc/nodejs/README.Debian

modbus@0.0.12 preuninstall /usr/local/lib/node_modules/modbus rm -rf libmodbus build

npm ERR! modbus@0.0.12 install: ./make_libmodbus.sh && node-gyp configure --python=python2 && node-gyp build npm ERR! sh "-c" "./make_libmodbus.sh && node-gyp configure --python=python2 && node-gyp build" failed with 2 npm ERR! npm ERR! Failed at the modbus@0.0.12 install script. npm ERR! This is most likely a problem with the modbus package, npm ERR! not with npm itself. npm ERR! Tell the author that this fails on your system: npm ERR! ./make_libmodbus.sh && node-gyp configure --python=python2 && node-gyp build npm ERR! You can get their info via: npm ERR! npm owner ls modbus npm ERR! There is likely additional logging output above.

npm ERR! System Linux 3.11.0-12-generic npm ERR! command "/usr/bin/nodejs" "/usr/bin/npm" "install" "-g" "modbus" npm ERR! cwd /root npm ERR! node -v v0.10.15 npm ERR! npm -v 1.2.18 npm ERR! code ELIFECYCLE npm ERR! npm ERR! Additional logging details can be found in: npm ERR! /root/npm-debug.log npm ERR! not ok code 0 andrey-w ~ # cat /usr/share/doc/nodejs/README.Debian|less

Reply to this email directly or view it on GitHubhttps://github.com/tuxnsk/nodejs_libmodbus/issues/3#issuecomment-34574896 .

Contacts: http://tuxnsk.ru/