tuxnsk / nodejs_libmodbus

libmodbus binding for nodejs
41 stars 66 forks source link

Bindings for rtu_get_rts/rtu_set_rts commented out #34

Closed jcwren closed 7 years ago

jcwren commented 7 years ago

I'm using a RS-485 adapter that requires RTS to be managed for transmitting. libmodbus supports this with the modbus_rtu_set_rts() function, but the bindings are commented out in src/main.cpp.

Are these function commented out because of a problem? If you need a way to test them, I have a small piece of C code (using libmodbus) that retrieves a few registers from a slave, and prints them out. I can test a similar piece of nodejs code for verification, if you like.

I'm also hoping that perhaps you can update nodejs_libmodbus to use the 3.1.4 version (latest) of libmodbus.

markdegrootnl commented 7 years ago

+1

markdegrootnl commented 7 years ago

See #35

Disminder commented 7 years ago

If you can - test this pull request please: https://github.com/tuxnsk/nodejs_libmodbus/pull/35 I don't have a devices, where I can test this. Btw, libmodbus in this project is 3.1.4, if you install it from github, not from npm.

Disminder commented 7 years ago

Done