update mt.patch to fix building with -Werror

gizero commented 10 years ago

fixes build with glibc that declares write() with attribute warn_unused_result causing an error when -Werror is enabled as per the provided configure script

chaser92 commented 10 years ago

isn't that fixed already? thanks anyway!

gizero commented 10 years ago

uhm... I see a configure.patch that looks like a workaround for this but I can't see it applied anywhere. Cloning from master and building on a couple of Ubuntu 12.04 boxes is still broken for me... can you point me to what you believe was the previous fix? Also I think that checking write() return value is a more appropriate approach than disabling -Werror

chaser92 commented 10 years ago

You're right, it's more appropriate. My patch was just a quick fix - tested it on my machine, but not after it was merged.

2014-02-07 gizero notifications@github.com:

uhm... I see a configure.patch that looks like a workaround for this but I can't see it applied anywhere. Cloning from master and building on a couple of Ubuntu 12.04 boxes is still broken for me... can you point me to what you believe was the previous fix? Also I think that checking write() return value is a more appropriate approach than disabling -Werror

Reply to this email directly or view it on GitHubhttps://github.com/tuxnsk/nodejs_libmodbus/pull/6#issuecomment-34516281 .

Pozdrawiam, Mariusz Kierski

markdegrootnl commented 9 years ago

Can you please either merge this pull request or add the configure.ac patch to make_libmodbus.sh?

tuxnsk commented 9 years ago

OK

tuxnsk / nodejs_libmodbus

update mt.patch to fix building with -Werror #6