search

tuxudo / macos_security_compliance

macOS Security Compliance module for MunkiReport
1 stars 0 forks source link

FR: Red should be non-compliant #1

Closed patgmac closed 4 months ago

patgmac commented 5 months ago

Love this new plugin. Suggestion: When something is 100% compliant, or has 0 failures, a color other than red should be used.

I think most of us associate red with failure, not passing.

tuxudo commented 5 months ago

What view are you seeing 100% compliant with red?

patgmac commented 4 months ago

Listings > Security Compliance.

When something is 100% under the "Compliance" column, it's red. Or when there are 0 failures under the "Failures" column, it's red.

image

patgmac commented 4 months ago

Well, all numbers under Failures are red, which I suppose is fine. But showing 100% compliant in red is my main compliant.

tuxudo commented 4 months ago

Thank you for bring this up, the 100.0% red compliance is now green. The logic used wasn't checking for 100.0, but instead for 100. Resolved in v1.1 of the module