Styling, formatting & bug fixes - Githubissues

tuya / tuya-iot-python-sdk

Tuya IoT Python SDK for Tuya Open API.

MIT License

130 stars 49 forks source link

Styling, formatting & bug fixes #32

Closed frenck closed 3 years ago

frenck commented 3 years ago

This PR fixes a bunch of things:

References to undeclared/unimported Dict (replaced by dict to fix it)
References to undeclared/unimported List (replaced by list to fix it)
References to undeclared/unimported abc.ABCMeta (replaced by ABCMeta to fix it)
Fixes #20, caused by a typo in expire_time
Adjusted a couple of places that used get() without a default, which may caused exceptions when the variable was later used in an iteration.

Styling improvements:

Replaces some CamelCase variables with snake_case variants
Use f-string formatting in many places
Use list-comprehensions
Sorted imports
Black code styling
Removed some commented/stale code

This PR has been tested against the latest Home Assistant development branch to ensure it's working.

martin3000 commented 3 years ago

I had a look into the changes and I could not find any typo corrections with expire_time