tuyen-vuduc / mapbox-maui

Mapbox library for MAUI
Other
39 stars 7 forks source link

Visibility property for MapboxLayer doesn't seem to work #25

Closed DincaAndrei2410 closed 1 month ago

DincaAndrei2410 commented 4 months ago

Trying to hide/show MapboxLayer doesn't work. I've checked HandleSourcesChanged method from MapboxViewHandler and there doesn't seem to be a logic that listens for changes to that property.

As a workaround after updating visibility, I manually call "OnPropertyChanged(nameof(Layers))"

tuyen-vuduc commented 3 months ago

@DincaAndrei2410 Yeah, that's right. I think we will use the controller base approach where will have a controller to call action on a particular layer/source. Listening to every individual property will cause a lot of headaches .

tuyen-vuduc commented 2 months ago

@DincaAndrei2410 Check out v11.5.1-alpha07 for SetLayerPropertyFor

DincaAndrei2410 commented 1 month ago

Looks good, closing issue