Allowing the user to set a custom SSH port #440

daonb commented 9 months ago

Updating webgl addon to solve renedring bug
Linding & documenting the changes
Removing a double fint scale and adding log
Linting
Letting the user edit port number #440
Fixing sshPort editing & adding test
Fixing xcode build phase
Upgrading the add command

Summary by CodeRabbit

New Features
- Introduced layout adjustments and synchronization features in the Window class.
- Added new methods for pane focus and UI button updates.
Improvements
- Enhanced the Form class for better readability and maintainability.
- Updated property types and method modifications in the Window class.
- Renamed hostname to destination in commands and gates for clarity.
Bug Fixes
- Fixed a flickering terminal issue related to "lazyvim."
Documentation
- Added a troubleshooting page and a development site link to the changelog.
Refactor
- Restructured the Gate class to include sshPort and updated instantiation of SSHSession.
- Refactored Pane class methods for better cursor movement and selection handling.
Chores
- Updated index.html to include a new "data-test" attribute for better testing.
- Modified build configuration in Xcode project to set the LANG environment variable.

coderabbitai[bot] commented 9 months ago

Walkthrough

The recent updates involve a series of refactoring and functionality enhancements across the codebase. Functions have been reformatted for better readability, types have been made consistent, and new methods and properties have been introduced in classes to improve UI handling and command processing. Notably, there is an emphasis on handling SSH connections more robustly, with changes to port parsing and attribute additions. The UI has also seen improvements with layout synchronization and flicker fixes, alongside documentation updates in the changelog.

Changes

Files	Change Summary
`aatp/common/utils.ts`, `aatp/ui/ui.spec.ts`	Reformatted `getTWRBuffer` function; added new tests.
`src/form.ts`	Modified type declarations; refactored and restructured `Form` class methods.
`src/window.ts`	Updated `Window` class with new methods for UI handling.
`src/commands.ts`, `src/gate.ts`	Renamed `hostname` to `destination`; added `sshPort` handling.
`CHANGELOG.md`	Added entries for terminal fix, troubleshooting page, and dev site link.
`index.html`	Modified HTML element to include new `data-test` attribute.
`ios/App/.../project.pbxproj`	Added `export LANG` in `shellScript` for build configuration.
`src/pane.ts`	Adjusted `fontSize`; refactored `Terminal` instantiation; updated methods.
`src/terminal7.ts`	Refined event handling and asynchronous behavior in `Terminal7` class.

Poem

🐇✨ In the burrows of code, we refine and tune,
With each keystroke, a developer's boon.
SSH ports align, UI flickers fade,
A rabbit's work, in bytes and bits, is made.
🌟🚀

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ?

Tips

### Chat with CodeRabbit Bot (`@coderabbitai`) - You can reply to a review comment made by CodeRabbit. - You can tag CodeRabbit on specific lines of code or files in the PR by tagging `@coderabbitai` in a comment. - You can tag `@coderabbitai` in a PR comment and ask one-off questions about the PR and the codebase. Use quoted replies to pass the context for follow-up questions. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - The JSON schema for the configuration file is available [here](https://coderabbit.ai/integrations/coderabbit-overrides.v2.json). - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json`

netlify[bot] commented 9 months ago

Deploy Preview for terminal7 ready!

Name	Link
Latest commit	873dd5a3fa8c704bda69ee11af85c1b491ec446d
Latest deploy log	https://app.netlify.com/sites/terminal7/deploys/6581d69e219d2b0008d0b412
Deploy Preview	https://deploy-preview-448--terminal7.netlify.app/
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 9 months ago

Deploy Preview for dazzling-kringle-090742 ready!

Name	Link
Latest commit	873dd5a3fa8c704bda69ee11af85c1b491ec446d
Latest deploy log	https://app.netlify.com/sites/dazzling-kringle-090742/deploys/6581d69ebfd12000070c0dec
Deploy Preview	https://deploy-preview-448--dazzling-kringle-090742.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

tuzig / terminal7