search

tv2regionerne / statamic-private-api

MIT License
3 stars 3 forks source link

[v4.x] Remove entry does not work anymore #27

Closed sdussaut closed 4 months ago

sdussaut commented 4 months ago

Hi!

I updated my local installation with Statamic 5 and Private API 4 and it seems that the Entry deletion does not work anymore.

I get the following message:

"Method Statamic\\Http\\Controllers\\CP\\Collections\\EntriesController::destroy does not exist."

The method was there in Statamic v4.x as seen here https://github.com/statamic/cms/blob/7cbc505da6c7f2f9568599631b607aa427d5cc62/src/Http/Controllers/CP/Collections/EntriesController.php#L434

but seems to have disappeared with the 5.x update (https://github.com/statamic/cms/blob/5.x/src/Http/Controllers/CP/Collections/EntriesController.php).

SylvesterDamgaard commented 4 months ago

@sdussaut Ok. I will go through all the endpoints and verify them in V5.

sdussaut commented 4 months ago

@SylvesterDamgaard Thanks! If I can be of any help, please tell me.

SylvesterDamgaard commented 4 months ago

@sdussaut PR's are always welcome. :)

sdussaut commented 4 months ago

I narrowed down the change in Statamic codebase to this commit https://github.com/statamic/cms/commit/b8af5947fca101c8ca51d5fd563e0b971a5cecae but I am afraid this is as far as I can go with my very light Laravel/PHP skills 😅

SylvesterDamgaard commented 4 months ago

@sdussaut I have updated the code and tests now. #29 A new release will come out today.