search

tvallotton / rocket_auth

An implementation for an authentication API for Rocket applications.
https://docs.rs/rocket_auth/
Apache License 2.0
73 stars 35 forks source link

Fixed compile error and lowercase email on signup #42

Closed ywegel closed 2 years ago

ywegel commented 2 years ago

As you probably did not have time to fix these problems, i did it myself in a fork to use in my own project. You can merge this PR if this is useful to you

yzernik commented 2 years ago

I'm trying to get this branch to compile and to make the tests pass, but I get this. Am I doing something wrong?

$ cargo test
warning: unused `Rocket` that must be used
  --> examples/postgres.rs:65:5
   |
65 | /     rocket::build()
66 | |         .mount(
67 | |             "/",
68 | |             routes![
...  |
83 | |         .await
84 | |         .unwrap();
   | |__________________^
   |
   = note: `#[warn(unused_must_use)]` on by default

warning: unused `Rocket` that must be used
  --> examples/sqlite.rs:67:5
   |
67 | /     rocket::build()
68 | |         .mount(
69 | |             "/",
70 | |             routes![
...  |
85 | |         .await
86 | |         .unwrap();
   | |__________________^
   |
   = note: `#[warn(unused_must_use)]` on by default

warning: unused `Rocket` that must be used
  --> examples/mysql.rs:65:5
   |
65 | /     rocket::build()
66 | |         .mount(
67 | |             "/",
68 | |             routes![
...  |
83 | |         .await
84 | |         .unwrap();
   | |__________________^
   |
   = note: `#[warn(unused_must_use)]` on by default

warning: unused `Rocket` that must be used
  --> examples/redis.rs:67:5
   |
67 | /     rocket::build()
68 | |         .mount(
69 | |             "/",
70 | |             routes![
...  |
85 | |         .await
86 | |         .unwrap();
   | |__________________^
   |
   = note: `#[warn(unused_must_use)]` on by default

warning: unused `Rocket` that must be used
   --> examples/tokio_postgres.rs:81:5
    |
81  | /     rocket::build()
82  | |         .mount(
83  | |             "/",
84  | |             routes![
...   |
99  | |         .await
100 | |         .unwrap();
    | |__________________^
    |
    = note: `#[warn(unused_must_use)]` on by default

warning: `rocket_auth` (example "postgres") generated 1 warning
warning: `rocket_auth` (example "sqlite") generated 1 warning
warning: `rocket_auth` (example "mysql") generated 1 warning
warning: `rocket_auth` (example "redis") generated 1 warning
warning: `rocket_auth` (example "tokio_postgres") generated 1 warning
    Finished test [unoptimized + debuginfo] target(s) in 0.94s
     Running unittests src/lib.rs (target/debug/deps/rocket_auth-60ed53a452066651)

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests rocket_auth

running 34 tests
test src/user/auth.rs - user::auth::Auth (line 15) - compile ... ok
test src/lib.rs - (line 45) - compile ... ok
test src/lib.rs - AdminUser (line 178) ... ok
test src/lib.rs - (line 127) ... ok
test src/lib.rs - (line 106) ... ok
test src/lib.rs - User (line 157) ... ok
test src/lib.rs - (line 86) ... ok
test src/user/auth.rs - user::auth::Auth::change_email (line 269) ... ok
test src/user/auth.rs - user::auth::Auth::change_password (line 248) ... ok
test src/user/auth.rs - user::auth::Auth::delete (line 228) ... ok
test src/user/auth.rs - user::auth::Auth::get_session (line 296) ... FAILED
test src/user/auth.rs - user::auth::Auth::login (line 83) ... ok
test src/user/auth.rs - user::auth::Auth::get_user (line 192) ... ok
test src/user/auth.rs - user::auth::Auth::logout (line 213) ... ok
test src/user/auth.rs - user::auth::Auth::is_auth (line 171) ... ok
test src/user/auth.rs - user::auth::Auth::login_for (line 106) ... ok
test src/user/auth.rs - user::auth::Auth::signup_for (line 152) ... ok
test src/user/auth.rs - user::auth::Auth::signup (line 134) ... ok
test src/user/user_impl.rs - user::user_impl::User::email (line 60) ... ok
test src/user/user_impl.rs - user::user_impl::User::set_email (line 75) ... ok
test src/user/user_impl.rs - user::user_impl::User::id (line 47) ... ok
test src/user/users.rs - user::users::Users (line 233) ... ok
test src/user/users.rs - user::users::Users (line 210) ... ok
test src/user/user_impl.rs - user::user_impl::User::set_password (line 15) ... ok
test src/user/users.rs - user::users::Users::create_user (line 157) ... ok
test src/user/users.rs - user::users::Users::open_postgres (line 75) - compile ... ok
test src/user/users.rs - user::users::Users::delete (line 177) ... ok
test src/user/users.rs - user::users::Users::modify (line 194) ... ok
test src/user/users.rs - user::users::Users::get_by_email (line 125) ... ok
test src/user/users.rs - user::users::Users::open_sqlite (line 11) - compile ... ok
test src/user/users.rs - user::users::Users::open_mysql (line 103) ... ok
test src/user/users.rs - user::users::Users::get_by_id (line 141) ... ok
test src/user/users.rs - user::users::Users::create_table (line 35) ... FAILED
test src/user/users.rs - user::users::Users::open_redis (line 52) ... FAILED

failures:

---- src/user/auth.rs - user::auth::Auth::get_session (line 296) stdout ----
error[E0624]: associated function `get_session` is private
   --> src/user/auth.rs:298:6
    |
5   | auth.get_session()?;
    |      ^^^^^^^^^^^ private associated function
    |
   ::: /home/yzernik/work/rocket_auth/src/user/auth.rs:302:5
    |
302 |     #[throws(Error)]
    |     ---------------- private associated function defined here

error: aborting due to previous error

For more information about this error, try `rustc --explain E0624`.
Couldn't compile the test.
---- src/user/users.rs - user::users::Users::create_table (line 35) stdout ----
Test executable failed (exit code 1).

stderr:
Error: SqlxError(Database(SqliteError { code: 14, message: "unable to open database file" }))

---- src/user/users.rs - user::users::Users::open_redis (line 52) stdout ----
Test executable failed (exit code 1).

stderr:
Error: SqlxError(Database(SqliteError { code: 14, message: "unable to open database file" }))

failures:
    src/user/auth.rs - user::auth::Auth::get_session (line 296)
    src/user/users.rs - user::users::Users::create_table (line 35)
    src/user/users.rs - user::users::Users::open_redis (line 52)

test result: FAILED. 31 passed; 3 failed; 0 ignored; 0 measured; 0 filtered out; finished in 8.78s

error: test failed, to rerun pass '--doc'
tvallotton commented 2 years ago

Sorry for taking so long, I'll be having some time for working on this crate soon. Thank you for contributing.

ywegel commented 2 years ago

No problem, thank you for merging :)