tvandinther / libsql-client-dotnet

A .NET client for libsql

https://www.nuget.org/packages/Libsql.Client

MIT License

60 stars 3 forks source link

Fix integration tests for MacOS and Windows runners #16

Closed tvandinther closed 8 months ago

tvandinther commented 9 months ago

The integration tests uses docker compose to create a libsql server to test against. The MacOS and Windows runners no longer come with docker installed so these tests fail to run.

s-e-f commented 9 months ago

Attempting to pick this up. It looks like docker is installed on the agent but since its Windows, it only supports Windows-based images. I believe the same problem exists on regular docker use in Windows.

Perhaps this can be solved by using a Windows agent that has docker configured for WSL? I'm not sure about Mac though...

tvandinther commented 8 months ago

After a brief search I think it could be worth exploring the WSL option. WSL2 doesn't seem to be supported yet but could be soon, so hopefully it can still work.

For MacOS it might just need brew install of the docker software components required in a previous step.

tvandinther commented 8 months ago

I'm going to try a proof of concept using test containers instead of docker compose.

tvandinther commented 8 months ago

23 is open. I have decided to skip tests requiring containers on platforms that don't support virtualisation on GitHub-hosted runners (Windows & macOS). I figure that running these extra tests on just Linux is sufficient along with a disclaimer in the README.