2b endpoints swb - Githubissues

tvaroglu / spot_me_backend

SpotMe is a 10-day, 6 person project, during Mod 3 of 4 for Turing School's Back End Engineering Program.

https://spotme-app.herokuapp.com

4 stars 1 forks source link

2b endpoints swb #34

Closed Scott-Borecki closed 3 years ago

Scott-Borecki commented 3 years ago

What I Did:

Create endpoints from database resources:
- GET /api/v1/gyms/:id
- POST /api/v1/users/:user_id/gyms/:gym_id/gym_members
- DELETE /api/v1/users/:user_id/gyms/:gym_id
Add edge case testing to POST /api/v1/users/:user_id/gyms/:gym_id/events
Set up test framework for:
- GET /api/v1/users/:user_id/gyms/:gym_id/events/new
- POST /api/v1/users/:user_id/friendships

Road Blocks

None

Test Coverage

[X] I have tested this code with RSpec:
- All tests passing.
- 141/142 test coverage (we have not used the json_error_response method yet)
The serializers were created with the json-apiserializer gem; however, we should consider adding tests for the serializers.
Validations need to be added to endpoint request edge cases and tested.

Questions/Notes:

We should add a pull request template :)

bfl3tch commented 3 years ago

Awesome work!