Open tvaroglu opened 3 years ago
Unrelated, but one thing we can update for readability is changing the routes.rb so that it uses :yelp_gym_id instead of :id as the named route parameter. Might be a little lift, but I think it would be an improvement for clarity.
routes.rb
:yelp_gym_id
:id
Here is the way in the Rails Guides: https://guides.rubyonrails.org/v5.2/routing.html#overriding-named-route-parameters
_Originally posted by @Scott-Borecki in https://github.com/tvaroglu/spot_me_frontend/pull/109#discussion_r721405294_
Unrelated, but one thing we can update for readability is changing the
routes.rbso that it uses:yelp_gym_idinstead of:idas the named route parameter. Might be a little lift, but I think it would be an improvement for clarity.Here is the way in the Rails Guides: https://guides.rubyonrails.org/v5.2/routing.html#overriding-named-route-parameters
_Originally posted by @Scott-Borecki in https://github.com/tvaroglu/spot_me_frontend/pull/109#discussion_r721405294_