Update JSON Contracts - Githubissues

tvaroglu / spot_me_frontend

SpotMe is a 10-day, 6 person project, during Mod 3 of 4 for Turing School's Back End Engineering Program.

https://spotme-app.herokuapp.com

3 stars 1 forks source link

Update JSON Contracts #96

Closed tvaroglu closed 2 years ago

tvaroglu commented 3 years ago

Card to track additional updates to JSON contracts based on stretch feature implementation.

General

[x] For the response body, use double quotes for keys and then colon instead of hash rocket.
[x] Check commas at the end of each line.

Users

[x] There is no goal no. 5 in the enums.

Events

[x] Create New Event:
- [x] Add response body.
- [x] Change user_id and gym_membership_id to be in the path instead of body in the Parameters.
- [x] GET /users/:id/events
- [x] Add optional query param time_frame=past for past_events
- [x] Update responses examples to include new meta keys for gym_name, yelp_gym_id, friend_name, and friend_role

Friendships

[x] Delete Friendship: The friendship_id should actually be the user_id in the docs?
[x] Get User's Followers (new feature, from current Friendships.Index endpoint via new query param relationship=followers)

Gym Memberships

[x] Delete Gym Membership: The gym_membership_id description should be the gym membership id?
[x] Update responses examples to include new meta keys for address and address_details

Gyms

[x] Update responses examples to include new attribute for gym_member_count