tvbarthel / BlurDialogFragment

Library project to display DialogFragment with a blur effect.
Apache License 2.0
2.09k stars 334 forks source link

added null check to make sure NPE isn't thrown onDestroy #42

Closed tomafc330 closed 9 years ago

tomafc330 commented 9 years ago

@vbarthel-fr what do you think of this? Thanks

tbarthel-fr commented 9 years ago

Hi @tommytcchan (:

First of all thanks a lot for your interest in this project!

As you mentioned this will avoid throwing exception but won't fix the source of concern.

Either the async should always be null, or never be. It should be linked to something we missed in the component lifecycle :(

We are currently short of time to garanty the support we would like to provide but we will definitively try to have a look this weekend!

Thomas.