Update to use the latest version of the stack blur algorithm as it wa…

tvbarthel / BlurDialogFragment

Library project to display DialogFragment with a blur effect.

Apache License 2.0

2.09k stars 334 forks source link

Update to use the latest version of the stack blur algorithm as it wa… #48

Closed tomafc330 closed 8 years ago

tomafc330 commented 9 years ago

…s causing IndexArrayOutOfBoundsException.

tomafc330 commented 9 years ago

Fixes this issue which we were also seeing with our clients:

https://github.com/tvbarthel/BlurDialogFragment/issues/36

Basically it's using a version of Stack Blur that was a little outdated

 // Stack Blur v1.0 from
-        // http://www.quasimondo.com/StackBlurForCanvas/StackBlurDemo.html
-        //
-        // Java Author: Mario Klingemann <mario at quasimondo.com>
-        // http://incubator.quasimondo.com
-        // created Feburary 29, 2004
-        // Android port : Yahel Bouaziz <yahel at kayenko.com>
-        // http://www.kayenko.com
-        // ported april 5th, 2012
...

Notice from the original code for Stack Blur, the IndexOutOfBoundsException was fixed in 08/2013:

19.08.2013: Added support for Alpha blurring

Basically took the Java code for the blur logic and put it in the library.

tomafc330 commented 9 years ago

@vbarthel-fr Could you review this? Thanks!

tomafc330 commented 9 years ago

Tested with the sample app...everything works.

tomafc330 commented 9 years ago

@vbarthel-fr Mind reviewing this? Thanks!

vbarthel-fr commented 9 years ago

@tommytcchan sorry for the delay, I'm quite busy at the moment, I will definitely take a look at what you did as soon as I have some free time.

Thanks for your contribution =)

tomafc330 commented 9 years ago

Okay no problem thanks!

On Wed, Oct 21, 2015 at 2:38 PM, Vincent Barthélémy < notifications@github.com> wrote:

@tommytcchan https://github.com/tommytcchan sorry for the delay, I'm quite busy at the moment, I will definitely take a look at what you did as soon as I have some free time.

Thanks for your contribution =)

— Reply to this email directly or view it on GitHub https://github.com/tvbarthel/BlurDialogFragment/pull/48#issuecomment-150032775 .

tomafc330 commented 9 years ago

@vbarthel-fr Hey there any updates on this?