search

tvbarthel / BlurDialogFragment

Library project to display DialogFragment with a blur effect.
Apache License 2.0
2.09k stars 334 forks source link

Lib size #61

Closed andro-jedi closed 8 years ago

andro-jedi commented 8 years ago

Hi there.

Why library is so heavy?? Dependencies JAR size (KB) 2094 Or dependencies size is doesn’t meter?

tbarthel-fr commented 8 years ago

Hi @PingForward (=

Library weight as well as method count is one of our priority when we try to release some of our work as open source.

Regarding the BlurDialogFragment project and based on your link :

From our point of view these numbers are acceptable and won't impact the size of your apk neither the method limit as much. As the project is open source, we didn't tried to reduce the method count more than needed to keep a balance between maintainability and number of method (basically, we always try to avoid a single method to perfom all the expected behavior just to have a method count artificially low).

Now, as you mentionned, the library has dependencies, which increase the impact of using BlurDialogFragment on your final apk. These dependencies are the following :

As these dependencies are used let's say 90+% of the time (am I wrong?), they already impact your apk even if you don't include blurdialogfragment. Therefore we didn't try to split the library into several part.

Would you be interested in a split such as ?

We are currently considering this question for a new project that we have just released last week. Most of developers' feedback were : "these libraries are light enough and proguard will remove un-needed code from dependencies for a release build". We are going to try to get more feedback on reddit, maybe you could give us yours here (: