search

tvbarthel / ChaseWhisplyProject

an augmented reality attempt
537 stars 269 forks source link

Rank 'Admiral' is displayed instead of 'Deserter' #5

Closed trestianp closed 11 years ago

trestianp commented 11 years ago

When Playing the second game ( the one after the tutorial) I noticed that if I made 400 points I got the Admiral rank.

Steps to reproduce:

  1. Start the Scouts First! mission
  2. Play and make a score smaller than 500.
  3. Check the rank at the end

Expected result: You get the rank "Deserter"

Actual result: You get the rank "Admiral"

Notes: I wasn't sure if it's ok to fork it and correct the bug myself , so I will tell you where you need to make the change. There are two places where this appears so I assume that this also happens on both game modes. In the src/main/java/fr/tvbarthel/games/chasewhisply/model/mode/GameModeMarathon.java and src/main/java/fr/tvbarthel/games/chasewhisply/model/mode/GameModeSprint.java In GameModeSprint.java Code line 47 says : 'return GameModeFactory.GAME_RANK_ADMIRAL;' and needs to be replaced with return GameModeFactory.GAME_RANK_DESERTER; Same change in GameModeMarathon.java on line 45 . Easy fix, I know.

vbarthel-fr commented 11 years ago

Thanks a lot :) if you want to request a pull, I'll be more than happy to merge it and give you the credit :)

But if you don't have the time, I can fix it myself. It's up to you !

trestianp commented 11 years ago

No, it's fine. You can fix it. I will play a little more with this app and let you know if I see any issues. I really like the idea and what you did .

vbarthel-fr commented 11 years ago

b0d62f9bc498a12bf3c682134aace3c0114951ca Thanks to you, it's fixed =)