search

tvcutsem / harmony-reflect

ES5 shim for ES6 Reflect and Proxy objects
http://www.ecma-international.org/ecma-262/6.0/#sec-reflection
Other
478 stars 48 forks source link

#48 Warning for using getOwnPropertyNames. #49

Closed ognjenb closed 9 years ago

ognjenb commented 9 years ago

I am using this fast fix temporary. If you want I can change this pull req according your thoughts or just simply reject it if its far away :)

Thanks

tvcutsem commented 9 years ago

Thanks for the PR. I'm going to hold off until I better understand why getOwnPropertyNames can still be invoked.

Meanwhile two comments on the patch: 1) line 845: since console.warn exists in both node.js and all supported browsers (Chrome/FF), there's no need for the logOut function. You can just call console.warn directly.

2) line 847: no need to do var that = this here. You can just use this directly.

tvcutsem commented 9 years ago

Closing this PR as the necessary changes are included in v1.2.1.