search

tvcutsem / harmony-reflect

ES5 shim for ES6 Reflect and Proxy objects
http://www.ecma-international.org/ecma-262/6.0/#sec-reflection
Other
478 stars 48 forks source link

Incompatible with Edge browser #59

Closed ghost closed 9 years ago

ghost commented 9 years ago

I'm tested with reflect.js Edge browser, but native Proxy stop working.

tvcutsem commented 9 years ago

Can you provide a little more information about what behavior you are observing and what behavior you were expecting instead?

Do you mean that after loading this library, the browser's native Proxy object is shadowed/inaccessible? How did you test for that?

ghost commented 9 years ago

I read code, and see that you are replace "Proxy" object to empty function for "incompatible" browsers. But this is not good for edge. By test just try use proxy function with this lib.

tvcutsem commented 9 years ago

I see what you mean. I will add a feature-test that leaves the Proxy object untouched if the new API is already implemented.

2015-08-25 18:31 GMT+02:00 acterhd notifications@github.com:

I read code, and see that you are replace "Proxy" object to empty function. But this is not good for edge.

— Reply to this email directly or view it on GitHub https://github.com/tvcutsem/harmony-reflect/issues/59#issuecomment-134662503 .

tvcutsem commented 9 years ago

Should be fixed in v1.4.2. The original Proxy object should be left untouched.

Let me know if you encounter any further issues.