search

tvcutsem / harmony-reflect

ES5 shim for ES6 Reflect and Proxy objects
http://www.ecma-international.org/ecma-262/6.0/#sec-reflection
Other
478 stars 48 forks source link

Add license field with SPDX expression. #76

Closed goloroden closed 7 years ago

goloroden commented 7 years ago

Hi @tvcutsem 😊!

I was missing the license field in the package.json file, hence I added it.

In the LICENSE file you state that this module is dual-licensed, I assume this means that I can choose which license to apply. If not, and if you meant that I have to pay attention to both licenses at the same time, the OR in the SPDX expression needs to be replaced by an AND.

goloroden commented 7 years ago

Thanks for merging 😊

If I see this right, this also closes #75.

It would be great if you could release a new version with the license field :-)

tvcutsem commented 7 years ago

Thanks. Your interpretation was correct: you can choose which license to apply.

Yup, will close #75 and will release new version.

goloroden commented 7 years ago

PS: I'm very sorry, but I have seen after you had merged my PR, that I introduced a typo in package.json :-(

PR #77 fixes this :-)

tvcutsem commented 7 years ago

harmony-reflect v1.5.1 contains your patch.