tvdboom / ATOM

Automated Tool for Optimized Modelling

https://tvdboom.github.io/ATOM/

MIT License

152 stars 14 forks source link

Development #28

Closed jaswinder9051998 closed 2 years ago

jaswinder9051998 commented 2 years ago

Related Issue or bug

Info about Issue or bug.

Fixes: #[issue number that will be closed through this PR]

Type of change

[ ] Bug fix (non-breaking change which fixes an issue).
[x] New feature (non-breaking change which adds functionality).
[ ] Code style update (formatting, local variables).
[ ] Breaking change (fix or feature that would cause existing functionality to stop working).
[ ] This change requires a documentation update.

Describe the changes you've made

addition of zoofs algos for feature selection

How has this been tested?

test_solver_parameter_empty_zoofs
test_transform_zoofs
test_objective_function_zoofs

Is there any unusual behaviour in your code?

A clear and concise description of it.

Checklist:

[x] My code follows the style guidelines of this project.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] I have made corresponding changes to the documentation.
[x] My changes generate no new warnings.
[x] I have added tests that prove my fix is effective or that my feature works.
[x] New and existing unit tests pass locally with my changes.
[x] Any dependent changes have been merged and published in downstream modules.

Screenshots

Original	Updated
original screenshot	updated screenshot

jaswinder9051998 commented 2 years ago

@tvdboom you can review the changes, all of what we had discussed is covered

codecov-commenter commented 2 years ago

Codecov Report

Merging #28 (edaaeaf) into development (6b7b34b) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@             Coverage Diff              @@
##           development      #28   +/-   ##
============================================
  Coverage        99.95%   99.95%           
============================================
  Files               36       36           
  Lines            10401    10466   +65     
============================================
+ Hits             10396    10461   +65     
  Misses               5        5

Impacted Files	Coverage Δ
atom/feature_engineering.py	`100.00% <100.00%> (ø)`
tests/test_feature_engineering.py	`100.00% <100.00%> (ø)`
atom/utils.py	`100.00% <0.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6b7b34b...edaaeaf. Read the comment docs.

jaswinder9051998 commented 2 years ago

All Relevant changes made

tvdboom commented 2 years ago

Approved. You can merge now.

jaswinder9051998 commented 2 years ago

Only those with write access to this repository can merge pull requests.

@tvdboom I don't think I've been granted write access