search

tvdboom / ATOM

Automated Tool for Optimized Modelling
https://tvdboom.github.io/ATOM/
MIT License
152 stars 14 forks source link

Branching breaks voting #7

Closed bmnds closed 2 years ago

bmnds commented 3 years ago

Hi, first of all, I would like to thank you for developing such a great library! Being able to simply add models, branch off of it, experiment new models and techniques and compare all of it with few lines of code is something I was searching for some time and this lib looks really promising!!!

So here is my model against a custom dataset: image

Thing is, if I try to use .voting() outside the master branch, I get this error: image

tvdboom commented 3 years ago

Hi. Thanks for taking an interest in the library.

The error raises because you create a branch with the same name as the acronym of the voting model, vote. This confuses atom since it doesn't know if you are talking about the branch or the model. To avoid this, just give your branch a different name. I'll make sure next release raises a proper error when you try to create a branch using a models' acronym. Thanks for pointing this out. Let me know if you encounter anymore problems.

bmnds commented 3 years ago

I see, I'll try to dig into the lib and create a pull request myself about this :) Thanks

bmnds commented 3 years ago

Are there any contribution guidelines I could follow to get started?

tvdboom commented 3 years ago

I already fixed it this morning. It's in the latest push to the development branch. I haven't made a contribution guideline but I was planning to, so I'll try to do it this week. Feel free to create a PR if you solve a bug or add a new feature.