tvdsluijs / sh-python-installer

General easy to use Raspberry Pi & Ubuntu Python installer
MIT License
70 stars 19 forks source link

Script uses bash but declares sh #20

Closed hlascelles closed 2 months ago

hlascelles commented 2 months ago

If you run this script, say, in docker, it uses sh: https://github.com/tvdsluijs/sh-python-installer/blob/34905d6d66bcab9405d6292685256cf6397fbe5f/python.sh#L1

But that fails as the script requires bash:

43: python.sh: [[: not found

Should the shebang be changed:

# From:
#!/usr/bin/env sh

# To:
#!/usr/bin/env bash
tvdsluijs commented 2 months ago

Consider it done

hlascelles commented 2 months ago

:bow: