tvdstaaij / node-git-describe

Git describe information at runtime, with semver support
36 stars 5 forks source link

fix: Bump version of semver to address vulnerability warnings #32

Open TimothyJones opened 1 year ago

TimothyJones commented 1 year ago

This PR:

1) Bumps the version of semver to address the vulnerabiltiy warning 2) Fixes the test that broke after the version bump (this is the reason that this automated PR failed) 3) Swaps the deprecated standard-version for the most popular fork, commit-and-tag-version, which additionally addresses some vulnerability warnings.

Full disclosure, I maintain commit-and-tag-version - it's a fork of the now-unmaintained standard-version, which has had some good traction. Aside: this repository now doesn't actually need either tool - it would be better to use release-please, which is a much more streamlined release process for repositories hosted in github.

@tvdstaaij The semver issue is causing a few downstream vulnerability warnings - it would be awesome to get this in and released. Let me know if you'd like a version of this PR without introducing a tool that I maintain - I remember you were quite careful with security.

Hope you're well!