tve / lx16a-servo

Simple ESP32-Arduino library to operate LX-16A serial servos
MIT License
21 stars 17 forks source link

can you publish this library into the arduino library manager? #2

Open madhephaestus opened 4 years ago

madhephaestus commented 4 years ago

as per these instructions: https://github.com/arduino/Arduino/wiki/Library-Manager-FAQ

You need a

library.properties

and to add the library to the Arduino issues to be added to the manager. Here is an example of someone else adding a new library: https://github.com/arduino/Arduino/issues/9648

You will then just need to tag the repo with a version number matching the library.properties version number.

If you have no intent to publish through the manager, would you object to me forking and doing that?

tve commented 4 years ago

Thanks for the interest & info. I don't use the Arduino IDE at all, so I don't want to spend the effort to do all this. I'm happy to take a PR though and of course you're free to fork.

madhephaestus commented 4 years ago

I'd be happy to make the changes and PR it, but the tagging updates and keeping that in sync with the library.properties file would need to be on you.

tve commented 4 years ago

I can handle the tagging etc.

dalemcbeath commented 4 years ago

Hi, I'd really like this to happen. Just pulling the code over to a project and manually adding the library didn't work. Would be nice to have some example code in Arduino format. (would be happy to include code and errors if that would help)...

One question... is this supposed to work with the servos directly (as the title implies) or with the "required" servo controller board?

thanks,

dale

tve commented 4 years ago

I use a single pin on the esp32 to connect the servos, use at least a resistor of a few hundred ohms to protect the esp32 a bit from the 5v. A level shifter would be most proper...

dalemcbeath commented 4 years ago

so you are communicating with the servos directly via serial bus, not using the Buslinker v2.2 board? That's wonderful!