search

tve / lx16a-servo

Simple ESP32-Arduino library to operate LX-16A serial servos
MIT License
21 stars 17 forks source link

Upgrading library for production #5

Closed madhephaestus closed 4 years ago

madhephaestus commented 4 years ago

In this PR i am adding all of the changes to use this servo with all of its features.

The first update is to add electrical connection documentation.

The printf() functon is replaced with the Arduino compatible Serial.printf().

Formatting to adhere to C++ conventions.

Implement as many commands as possible.

tve commented 4 years ago

Hey, if you could like to take over this library I'm happy to put a link to yours into the readme in my repo. I still have HW running this but I will be converting it to MicroPython in the coming months. As such, I won't have time to test PRs and the library, as I have it, works for my needs for now.

madhephaestus commented 4 years ago

I wouldn't mind making my fork the main branch included in Arduino Library manager, i just wouldn't want to take the credit away from you :)

Thank you so much for the hard work getting it started. I am going through and applying Arduino and C++ conventions at the moment, but intend to switch over to adding commands and making this a full-feature library for use with these motors.

tve commented 4 years ago

I'd be happy to point to yours. Just leave a pointer back to mine as original/initial/... version somewhere.

madhephaestus commented 4 years ago

I will keep the source history and the GitHub link back to the original. Ill start adding it to Arduino now :D