search

tvelocity / dockerfiles

My collection of Dockerfiles for various services.
15 stars 39 forks source link

Running on the port 80? #8

Closed pierreozoux closed 9 years ago

pierreozoux commented 9 years ago

Hi,

I usually run web services under port 80. Do you think we could maybe use an env variable for that?

Thanks!

Piere

tvelocity commented 9 years ago

Hello,

It is trivial to map the exposed port to the host's port 80. I'd be reluctant to add more complexity to an image for something you can already do with docker.

Is there something you can't do now that this would enable you to do?

pierreozoux commented 9 years ago

I mean, not on the host, but from the docker container.

This is a convention that I use. Web services run on 80 internally, then I expose them outside though an SSL offloader. From my perspective, it gets complicated if I have to use a different port for every application.

If you don't want, I'm fine, I'll use my image, but if you want, I PR, and then we use the same image :)

Up to you!

tvelocity commented 9 years ago

I see, then.

If you're going to go into the trouble of implementing it, then sure go ahead and PR; maybe someone else will find the feature useful as well. :)