search

tvhong / incremental-reading

Anki add-on providing incremental reading features
https://ankiweb.net/shared/info/935264945
ISC License
33 stars 7 forks source link

Can you please make it compatible with FSRS4Anki ? #23

Closed lucatortiglione closed 2 months ago

lucatortiglione commented 1 year ago

Please, make it compatible with that awesome addon https://github.com/open-spaced-repetition/fsrs4anki

tvhong commented 1 year ago

Hi, Could you please provide issue reproduction steps?

lucatortiglione commented 1 year ago

Hi, Could you please provide issue reproduction steps?

Hi! i just wanted to get you aware of the fact the addon isn't compatible. I'm not able to use your addon yet. I think you could contact fsrs author and ask him.

If you go on the main page of the other addon you will read "It shows the interval given by Anki's built-in scheduler, not the custom scheduler"

IshiRenga commented 1 year ago

I'm not sure why OP didn't provide you with the required details to understand the issue entirely, but allow me to do that as I have also run into this bug. The OP is referring to an incompatibility with the custom scheduling feature in Anki's V3 scheduler (FSRS is one such custom scheduler). When the incremental reading add-on is enabled, the custom scheduler doesn't seem to work. By that I mean that the intervals given to a card are from Anki's default algorithm instead of the custom one. I believe to solve this issue would mean fixing this incompatibility.

tvhong commented 1 year ago

@IshiRenga thank you for providing the details.

Is this happening when you have a deck with a mix of both IR3 (Incremental Reading) cards and normal cards? Or also happen for decks with purely normal cards?

Do you have easy reproduction steps (+ expected outcome)? I'm not very familiar with how interval settings differ between the default Anki vs. FSRS work.

tvhong commented 1 year ago

I also just saw that FSRS is being integrated into Anki 23.10

FSRS has been integrated into Anki. If your version of Anki is 23.10 or newer, use the built-in FSRS. Read about how to use it here. If your version of Anki is 2.1.66 or older, use the standalone version.

https://github.com/open-spaced-repetition/fsrs4anki#how-to-get-started

Would be interesting to see whether this bug just automatically go away when we use 23.10.

galantra commented 1 year ago

Would be interesting to see whether this bug just automatically go away when we use 23.10.

The native FSRS can be enabled and disabled per deck options group, so I guess that this shouldn't pose a problem.

However, 23.10 has also brought some other changes: https://forums.ankiweb.net/t/porting-tips-for-anki-23-10/35916/ Do they affect IR?

tvhong commented 1 year ago

Thanks for sharing the link!

Another user already reported compatibility issue with Qt5 that I already fixed: https://github.com/tvhong/incremental-reading/issues/28

I see that IR uses note.flush(). So I'll make a small fix for that as well.

tvhong commented 1 year ago

Another user also report FSRS issues on Anki forum: https://forums.ankiweb.net/t/incremental-reading-add-on-unofficial-clone/21331/15

They also suggested a fix. I'll try to reproduce and evaluate the fix.