search

tvillarete / ipod-classic-js

An iPod Classic emulator that connects to Apple Music and Spotify. Built with React & Styled Components
http://tannerv.com/ipod
MIT License
1.45k stars 107 forks source link

Added 2048 Game #105

Closed Lukas1h closed 9 months ago

Lukas1h commented 2 years ago

Added 2048 to the games list. Ported from https://github.com/kwrush/react-2048

BTW, Great project! Absolutely love it!

vercel[bot] commented 2 years ago

Someone is attempting to deploy a commit to a Personal Account owned by @tvillarete on Vercel.

@tvillarete first needs to authorize it.

vercel[bot] commented 2 years ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ipod-classic-js ❌ Failed (Inspect) May 25, 2022 at 8:09PM (UTC)
tvillarete commented 2 years ago

Hey @Lukas1h, thanks for contributing! It would be awesome to have 2048 as an iPod game. Unfortunately it doesn't look like this is in a functioning state in its current form. A couple things I've noticed while trying to test it out:

  1. I see a new dependency called styled-normalize is used, however it hasn't been added to the root package.json which is causing a runtime error. Try running yarn add styled-normalize to fix that
  2. After getting the game at least in a runnable state, I'm seeing that the first screen I'm presented with is "game over". I think there might be an incorrect initial game state getting set
  3. The iPod screen's height just slightly increases when entering the 2048 game from the Games menu. We might need to adjust the styles within the game so it doesn't stretch the height of the screen
  4. I see that there are quite a few unused variables throughout your code. I'd recommend installing ESLint if you use VSCode. It will show you several useful warnings to make your code more resilient

Let me know if you need guidance on any of these points -- happy to help wherever possible 🙂

I'm going to convert this PR into a Draft PR since it still needs some iteration, but I'll be watching it for any comments. Thanks again!

tvillarete commented 9 months ago

Going to close this as it's quite out of date now. If you ever feel compelled to resurrect it in the future, I'll happily give it a review 🙂

Lukas1h commented 9 months ago

Yeah it's been awhile 😂

I don't think I'll ever get around to fixing the code.

Also thanks for your polite comment. I was a lot younger (only 14) and a lot less experienced and looking back now the code is pretty crazy.