search

tvjsx / trading-vue-js

💹 Hackable charting lib for traders. You can draw literally ANYTHING on top of candlestick charts. [Not Maintained]
https://tvjsx.github.io/trading-vue-demo/
MIT License
2.09k stars 638 forks source link

Timestamp representation on the x-axis , weird jump #117

Closed ghost closed 4 years ago

ghost commented 4 years ago

Timestamp string representation on the botbar has an issue

Example: the time 25th Jun 0:00 - 4:00 appears at the end of the day Jun25th day, the same continues for everyday

<------------25------------------------>|<------------26------------> <25: 4am-12night><25:0 am - 4 am>|<26: 4am-12night><26:0 am - 4 am>

the timestamp string representation alone should have been an error.(something to do with localtime vs GMT time representation? ) data - Copy.zip

C451 commented 4 years ago

Nice catch, btw use the issue template next time

https://github.com/tvjsx/trading-vue-js/commit/a75742f8b663d89454d7fa5f4581bfa1fd11fc34

ghost commented 4 years ago

Thanks. will check to use the issue template.

ghost commented 4 years ago

Unlike TradingView, and other graphs , a day is represented before its date is displayed on x-axis ie todays date being 9 th on the x-axis we dont see 9, rather 8 is seen and candles appearing after it pertain to the todays

8th , 9th of a month represented appropriately.

<-------8th------><-------9th------>

x: axis : TradingVue ===========8===========9 x:axis : TradingView 8==========9===========10 Do you think the regular standard is to be implemented

C451 commented 4 years ago

I believe I fixed that in the commit above, didn't build the dist yet.

ghost commented 4 years ago

You fixed the jump as mentioned in the bug initially, this is not actually a bug, this is where we represent the day on the x-axis after the day is over or before the day starts tradingView starts it with that day

TradingVue ends it with that day

Untitled
C451 commented 4 years ago

Maybe you need to set UTC on tv.com compare_tv_tvjs

ghost commented 4 years ago

hmmm thats(tradingVue time axis) is different for me 9 shows up wherer it shows 10 for you . Will check Thanks for responding