Custom OHLC data style

[adsonvinicius]

I'm trying to custom the ohlcv info shown on chart but no success. I found the code below on Legend.vue

<span class="t-vue-lspan" >{{ohlcv[0]}}</span>

However it seems the t-vue-lspan class has been overridden in some other place than Legend.vue because changing CSS props on this file doesn't reflect on chart. So before to create a new class on this file to customize it, I would like to know if there's any explanation about this behavior.

[C451]

What do you mean by 'doesn't reflect on chart'?

[adsonvinicius]

I mean, if I change any CSS prop on this class and rebuild it, I can't see changes. In my case I was trying to change font-size and color.

On Sat, 14 Nov 2020 at 03:59 C451 notifications@github.com wrote:

[image: image] https://user-images.githubusercontent.com/48596328/99141807-e4f5e180-265f-11eb-831f-1aca95bff3f1.png What do you mean by 'doesn't reflect on chart'?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/tvjsx/trading-vue-js/issues/156#issuecomment-727157277, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADRAKW56CBU2G3SLZEVAOH3SPYTD5ANCNFSM4TVGIJKA .

-- Atenciosamente,

Adson Damasceno

[C451]

I just tried to change the .t-vue-lspan color in the code and it worked. And also this is not a specific library issue (there is a lot resources about Vue & css on the internet).

[adsonvinicius]

I see. If you say it worked I will checkout from github again and rebuild it. I confess it was weird do not see any changes where it seems pretty simple (and obvious) code edition.

About being an issue, If this CSS prop wouldn't have changed the display behavior of something, why I couldn't consider as an issue? I'm asking to avoid do this again for similar problems in future.

On Sat, 14 Nov 2020 at 09:21 C451 notifications@github.com wrote:

Closed #156 https://github.com/tvjsx/trading-vue-js/issues/156.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/tvjsx/trading-vue-js/issues/156#event-3996380268, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADRAKW3G5VYRNNR3PCMQDKTSPZY4DANCNFSM4TVGIJKA .

-- Atenciosamente,

Adson Damasceno

[C451]

Imagine that tvjs is a black box. If you get bad results manipulating its inputs - that't a legit issue. If you enter the box (changing the code) that's an unmaintainable territory.

[adsonvinicius]

It makes sense. About the "issue" I cloned the repository, rebuild it, checked the problem persists. I also could see that CSS style from Legend.vue was generated twice on vue build files, so when I was changing in the component CSS code it was always overridden by the default code.

So you mean this is a vue-css issue and not the library issue?

[C451]

Yeah, it can be duplicated bc you have multiple legends. CSS has a solution for overwriting props, so I think this is ok. I could use scoped style but that way it would be impossible to overwrite colors on multiple instances.

[adsonvinicius]

Ah ok, I will use the CSS solution on my app then. Thanks.